Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add wheel builds #5009

Merged
merged 145 commits into from
Dec 1, 2022
Merged

Add wheel builds #5009

merged 145 commits into from
Dec 1, 2022

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Nov 18, 2022

This PR enables building wheels of cuml. I don't expect tests to pass here until the raft wheels PR is merged, but it should be ready for reviews and hopefully CI will provide some useful feedback in the interim.

sevagh and others added 30 commits September 21, 2022 22:01
@sevagh
Add initial cibuildwheel workflow
88f2284
@sevagh
Add python packaging files to cpp for libcuml
cc32a23
@sevagh
Install libcumlprims_mg before building libcuml
03772f5
@sevagh
DRY combined wheel workflow
d5fa3b2
@sevagh
Use correct workflow name
80771d9
@sevagh
Arch-specific smoketest-before
a8440d7
@sevagh
Add override
d8d2d1d
@sevagh
Install cuml wheel deps
434ecf5
@sevagh
Omit mkl, not on aarch64
cfba0d0
@sevagh
Install libcuml for cuml wheel
d9ed4bb
@sevagh
Install libcuml before build
07f642f
@sevagh
Install libcumlprims_mg before build
a3df884
@sevagh
Add RAFT for cuml
247fd5c
@sevagh
Install libraft
faa2db0
@sevagh
Switch from -cuda11 to -cu11 suffix
a399042
@trxcllnt @sevagh
set cuML wheels building
830fa9d
@trxcllnt @sevagh
add missing includes
3a1296f
@trxcllnt @sevagh
set include_package_data=True for scikit-build
f647245
@trxcllnt @sevagh
update github action to only build cuml wheel
7b2c172
@trxcllnt @sevagh
allow overriding cumlprims_mg branch and repo url
b4c05e5
@trxcllnt @sevagh
put envvars on one line, switch to my actions branch
bf786bb
@trxcllnt @sevagh
allow overriding the entire raft branch
05d3a10
@trxcllnt @sevagh
get joblib from raft-dask
ad477f0
@trxcllnt @sevagh
fix compile errors after raft moved things around
9158592
@trxcllnt @sevagh
define extras_require
bb0c1b3
@trxcllnt @sevagh
can't reference secrets in this file when the workflow_call action in…
8c4087b 
…herits them
@sevagh
Use new workflow syntax
c5a78e0
@sevagh
Test in 2_31
7fa4fa5
@sevagh
Install cupy for aarch64 before test
91cc142
@sevagh
Install pylibraft pre-test
63a3935
@vyasr vyasr requested a review from dantegd November 29, 2022 01:28
@sevagh sevagh mentioned this pull request Nov 29, 2022
Closed
@cjnolet cjnolet added this to PR-WIP in v22.12 Release via automation Nov 29, 2022
@vyasr vyasr mentioned this pull request Nov 30, 2022
Merged
@vyasr
Copy link
Contributor Author

vyasr commented Nov 30, 2022

Before merging this PR I will need to remove the logic for building wheels on push. I'm waiting to do so until I have enough approvals, but please do not merge this PR until after I have made that change.

@vyasr vyasr added 5 - DO NOT MERGE Hold off on merging; see PR for details and removed 3 - Ready for Review Ready for review by team labels Nov 30, 2022
v22.12 Release automation moved this from PR-WIP to PR-Reviewer approved Nov 30, 2022
@cjnolet
Copy link
Member

cjnolet commented Dec 1, 2022

rerun tests

@vyasr vyasr added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 5 - DO NOT MERGE Hold off on merging; see PR for details labels Dec 1, 2022
@vyasr
Copy link
Contributor Author

vyasr commented Dec 1, 2022

@gpucibot merge

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.12@8bdeb2c). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head 7e8a557 differs from pull request most recent head feaba8c. Consider uploading reports for the commit feaba8c to get more accurate results

Additional details and impacted files 
@@               Coverage Diff               @@
##             branch-22.12    #5009   +/-   ##
===============================================
  Coverage                ?   79.59%           
===============================================
  Files                   ?      184           
  Lines                   ?    11707           
  Branches                ?        0           
===============================================
  Hits                    ?     9318           
  Misses                  ?     2389           
  Partials                ?        0
Flag Coverage Δ
dask 46.00% <0.00%> (?)
non-dask 69.13% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rapids-bot rapids-bot bot merged commit 4b3928b into rapidsai:branch-22.12 Dec 1, 2022
v22.12 Release automation moved this from PR-Reviewer approved to Done Dec 1, 2022
@vyasr vyasr deleted the feat/cibuildwheel branch December 1, 2022 17:07
jakirkham pushed a commit to jakirkham/cuml that referenced this pull request Feb 27, 2023
@vyasr
Add wheel builds (rapidsai#5009)
debdd12 
This PR enables building wheels of cuml. I don't expect tests to pass here until the raft wheels PR is merged, but it should be ready for reviews and hopefully CI will provide some useful feedback in the interim.

Authors:
  - Vyas Ramasubramani (https://github.com/vyasr)
  - Sevag H (https://github.com/sevagh)
  - Paul Taylor (https://github.com/trxcllnt)

Approvers:
  - Joseph (https://github.com/jolorunyomi)
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#5009
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trxcllnt trxcllnt trxcllnt left review comments

@robertmaynard robertmaynard robertmaynard left review comments

@csadorf csadorf csadorf left review comments

@dantegd dantegd dantegd approved these changes

@jolorunyomi jolorunyomi jolorunyomi approved these changes

Assignees

@vyasr vyasr

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge CMake CUDA/C++ Cython / Python Cython or Python issue feature request New feature or request non-breaking Non-breaking change
Projects
No open projects
v22.12 Release
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@vyasr @cjnolet @codecov-commenter @trxcllnt @robertmaynard @dantegd @csadorf @jolorunyomi @sevagh