Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Treelite to 3.0.1 #5018

Merged
merged 3 commits into from
Nov 30, 2022
Merged

Upgrade Treelite to 3.0.1 #5018

merged 3 commits into from
Nov 30, 2022

Conversation

hcho3
Copy link
Contributor

@hcho3 hcho3 commented Nov 21, 2022 •
edited

I made a patch release 3.0.1 to support XGBoost 1.7 models.

Requires rapidsai/integration#565

@hcho3 hcho3 requested review from a team as code owners November 21, 2022 23:20
@github-actions github-actions bot added CMake conda conda issue CUDA/C++ gpuCI gpuCI issue labels Nov 21, 2022
@hcho3 hcho3 mentioned this pull request Nov 21, 2022
Merged
@hcho3 hcho3 added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 21, 2022
vyasr
vyasr requested changes Nov 23, 2022
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change planned for 22.12 or 23.02? If it's going into 22.12 we should make sure that the necessary updates are also made to #5009 (namely in setup.py).

@hcho3
Copy link
Contributor Author

hcho3 commented Nov 23, 2022

Yes, this is planned for 22.12, since it fixes support for the latest XGBoost.

@vyasr vyasr mentioned this pull request Nov 24, 2022
Merged
@hcho3
Copy link
Contributor Author

hcho3 commented Nov 29, 2022

rerun tests

@github-actions github-actions bot removed the gpuCI gpuCI issue label Nov 29, 2022
@cjnolet cjnolet added this to PR-WIP in v22.12 Release via automation Nov 29, 2022
@hcho3
Copy link
Contributor Author

hcho3 commented Nov 30, 2022

rerun tests

1 similar comment
@cjnolet
Copy link
Member

cjnolet commented Nov 30, 2022

rerun tests

@github-actions github-actions bot added the Cython / Python Cython or Python issue label Nov 30, 2022
@vyasr
Copy link
Contributor

vyasr commented Nov 30, 2022

I bumped the pip requirements in #5009 as well. Once I've confirmed that things install as expected there I'll approve here.

vyasr
vyasr approved these changes Nov 30, 2022
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Treelite on PyPI looks good to me.

v22.12 Release automation moved this from PR-WIP to PR-Reviewer approved Nov 30, 2022
@cjnolet
Copy link
Member

cjnolet commented Nov 30, 2022

rerun tests

@codecov-commenter
Copy link

Codecov Report

Base: 79.44% // Head: 79.49% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (0f010d3) compared to base (51a4fae).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@               Coverage Diff                @@
##           branch-22.12    #5018      +/-   ##
================================================
+ Coverage         79.44%   79.49%   +0.04%     
================================================
  Files               184      184              
  Lines             11698    11707       +9     
================================================
+ Hits               9293     9306      +13     
+ Misses             2405     2401       -4
Flag Coverage Δ
dask 46.00% <ø> (+0.07%) ⬆️
non-dask 69.03% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/cuml/comm/serialize.py 94.28% <0.00%> (-0.72%) ⬇️
python/cuml/common/input_utils.py 93.85% <0.00%> (ø)
python/cuml/model_selection/_split.py 75.88% <0.00%> (ø)
python/cuml/benchmark/nvtx_benchmark.py 0.00% <0.00%> (ø)
python/cuml/metrics/pairwise_kernels.py 79.83% <0.00%> (ø)
python/cuml/experimental/common/__init__.py 100.00% <0.00%> (ø)
python/cuml/common/array.py 97.36% <0.00%> (+0.10%) ⬆️
python/cuml/common/memory_utils.py 85.32% <0.00%> (+2.97%) ⬆️
python/cuml/neighbors/kernel_density.py 80.26% <0.00%> (+4.60%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cjnolet
Copy link
Member

cjnolet commented Nov 30, 2022

@gpucibot merge

1 similar comment
@cjnolet
Copy link
Member

cjnolet commented Nov 30, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 8bdeb2c into rapidsai:branch-22.12 Nov 30, 2022
v22.12 Release automation moved this from PR-Reviewer approved to Done Nov 30, 2022
@hcho3 hcho3 deleted the upgrade_treelite branch December 1, 2022 03:41
jakirkham pushed a commit to jakirkham/cuml that referenced this pull request Feb 27, 2023
@hcho3
Upgrade Treelite to 3.0.1 (rapidsai#5018)
780e50b 
I made a patch release 3.0.1 to support XGBoost 1.7 models.

Requires rapidsai/integration#565

Authors:
  - Philip Hyunsu Cho (https://github.com/hcho3)
  - Dante Gama Dessavre (https://github.com/dantegd)

Approvers:
  - Jake Awe (https://github.com/AyodeAwe)
  - Vyas Ramasubramani (https://github.com/vyasr)

URL: rapidsai#5018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr approved these changes

@AyodeAwe AyodeAwe AyodeAwe approved these changes

Assignees
No one assigned
Labels
CMake conda conda issue CUDA/C++ Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
No open projects
v22.12 Release
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@hcho3 @cjnolet @vyasr @codecov-commenter @AyodeAwe @dantegd