Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DBSCAN allocates rbc index even if deactivated #5859

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

mfoerste4
Copy link
Contributor

This fix addresses DBSCAN always reserving memory for the RBC index no matter whether the approach is activated or not. With the latest RBC index optimizations the memory consumption has increased which makes this more painful.

  • Keep RBC index empty when not used
  • Confirm index type sufficiently large to address data in RBC index

FYI, @tfeher

@mfoerste4 mfoerste4 requested a review from a team as a code owner April 23, 2024 15:37
@mfoerste4 mfoerste4 self-assigned this Apr 23, 2024
@mfoerste4 mfoerste4 added bug Something isn't working CUDA / C++ CUDA issue non-breaking Non-breaking change and removed CUDA/C++ labels Apr 23, 2024
Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dantegd
Copy link
Member

dantegd commented Apr 23, 2024

/merge

@rapids-bot rapids-bot bot merged commit 2b37aed into rapidsai:branch-24.06 Apr 23, 2024
59 of 60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CUDA / C++ CUDA issue CUDA/C++ non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants