Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DBSCAN allocates rbc index even if deactivated #5859

Merged
merged 2 commits into from
Apr 23, 2024
Merged

Fix DBSCAN allocates rbc index even if deactivated #5859

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7972b23
empty rbc index if deactivated, also check dimensions fit in index type
mfoerste4 Apr 23, 2024
f51706c
Merge branch 'branch-24.06' into fix_rbc_index_allocation
mfoerste4 Apr 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion cpp/src/dbscan/runner.cuh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,15 @@ std::size_t run(const raft::handle_t& handle,
return size;
}

if (sparse_rbc_mode && (std::size_t)D > static_cast<std::size_t>(MAX_LABEL / N)) {
CUML_LOG_WARN(
"You are using an index type of size (%d bytes) which is not sufficient "
"to represent the input dimensions in the RBC index. "
"Consider using a larger index type. Falling back to BRUTE_FORCE strategy.",
(int)sizeof(Index_));
sparse_rbc_mode = false;
}

// partition the temporary workspace needed for different stages of dbscan.

std::vector<Index_> batchadjlen(n_batches);
Expand Down Expand Up @@ -211,7 +220,7 @@ std::size_t run(const raft::handle_t& handle,
raft::neighbors::ball_cover::BallCoverIndex<Index_, Type_f, Index_, Index_>* rbc_index_ptr =
nullptr;
raft::neighbors::ball_cover::BallCoverIndex<Index_, Type_f, Index_, Index_> rbc_index(
handle, x, N, D, metric);
handle, x, sparse_rbc_mode ? N : 0, sparse_rbc_mode ? D : 0, metric);

if (sparse_rbc_mode) {
raft::neighbors::ball_cover::build_index(handle, rbc_index);
Expand Down
Loading