Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Cuda Array Interface input and data input code cleanup #612

Merged
merged 70 commits into from Jun 11, 2019
Merged

[REVIEW] Cuda Array Interface input and data input code cleanup #612

merged 70 commits into from Jun 11, 2019

Conversation

dantegd
Copy link
Member

@dantegd dantegd commented May 16, 2019 •
edited

Closes #369

Tasks:

  • Add tests for all methods
  • Add centralized method in input_utils.py to get inputs and convert them to device array
  • Add centralized method in input_utils.py for single column (series) inputs
  • Update classes to use method from input_utils.py. Subtasks
    • Update python classes
    • Update cython classes to allow them to also use same input methods in base.pyx

dantegd and others added 17 commits May 16, 2019 13:54
@dantegd dantegd mentioned this pull request May 21, 2019
Closed
@dantegd dantegd mentioned this pull request May 22, 2019
Closed
@dantegd dantegd requested a review from JohnZed May 28, 2019 15:17
@dantegd dantegd mentioned this pull request May 28, 2019
Closed
4 tasks
kkraus14
kkraus14 reviewed May 30, 2019
View reviewed changes
ci/gpu/build.sh Outdated Show resolved Hide resolved
kkraus14
kkraus14 suggested changes May 30, 2019
View reviewed changes
Copy link
Contributor

@kkraus14 kkraus14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly questions with some minor changes

python/cuml/cluster/dbscan.pyx Outdated Show resolved Hide resolved
python/cuml/cluster/kmeans.pyx Outdated Show resolved Hide resolved
python/cuml/decomposition/pca.pyx Show resolved Hide resolved
python/cuml/decomposition/tsvd.pyx Show resolved Hide resolved
python/cuml/test/test_coordinate_descent.py Show resolved Hide resolved
python/cuml/utils/input_utils.py Show resolved Hide resolved
python/cuml/utils/input_utils.py Outdated Show resolved Hide resolved
python/cuml/utils/input_utils.py Outdated Show resolved Hide resolved
python/cuml/utils/input_utils.py Outdated Show resolved Hide resolved
python/cuml/utils/input_utils.py Show resolved Hide resolved
v0.8 Release automation moved this from PR-WIP to PR-Needs review May 30, 2019
@dantegd dantegd requested a review from kkraus14 June 6, 2019 04:12
@dantegd
Copy link
Member Author

dantegd commented Jun 6, 2019

rerun tests

kkraus14
kkraus14 reviewed Jun 11, 2019
View reviewed changes
ci/gpu/build.sh Outdated Show resolved Hide resolved
v0.8 Release automation moved this from PR-Needs review to PR-Reviewer approved Jun 11, 2019
@dantegd @kkraus14
Update ci/gpu/build.sh
b20d811 
Co-Authored-By: Keith Kraus <keith.j.kraus@gmail.com>
@dantegd dantegd merged commit 5625433 into rapidsai:branch-0.8 Jun 11, 2019
v0.8 Release automation moved this from PR-Reviewer approved to Done Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkraus14 kkraus14 kkraus14 approved these changes

@cjnolet cjnolet Awaiting requested review from cjnolet

@Salonijain27 Salonijain27 Awaiting requested review from Salonijain27

@JohnZed JohnZed Awaiting requested review from JohnZed

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team Cython / Python Cython or Python issue tests Unit testing for project
Projects
No open projects
v0.8 Release
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Allow DeviceNDArray as input data
3 participants
@dantegd @JohnZed @kkraus14