Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python API for linestring polygon distance #1031

Merged
merged 56 commits into from
Apr 26, 2023
Merged

Python API for linestring polygon distance #1031

merged 56 commits into from
Apr 26, 2023

Conversation

isVoid
Copy link
Contributor

@isVoid isVoid commented Apr 4, 2023

Description

closes #1029

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@isVoid
initial
7022c1d
@isVoid
add segment iterator and tests
5686be3
@isVoid
WIP
a74af14
@isVoid
making progress towards getting the right index
1c28faa
@isVoid
commiting progress
243d2d9
@isVoid
able to get the right segment combinations from within the kernel, ne…
0da0afc 
…ed to test more rigidly
@isVoid
[skip-ci] initial port from feature/linestring_polygon_distance_header
49e43aa
@isVoid
Apply suggestions from code review
e8e45d0
@isVoid
Update cpp/include/cuspatial/experimental/detail/functors.cuh
fadf5c8
@isVoid
address review comments
fe31542
@isVoid
address review comments
af0c35e
@isVoid
[skip-ci] address review coments
05bf7ff
@isVoid
Add docstrings for functors
2435126
@isVoid
[skip-ci] adds linestring_count test
98a4a0f
@isVoid
[skip-ci] revert removed code
9b72723
@isVoid
style
6971200
@isVoid
update unexpected changes
6f7a226
@isVoid
license
641934f
@isVoid
Merge branch 'feature/segment_iterators' into feature/linestring_poly…
c580876 
…gon_distance_header
@isVoid
Update cpp/include/cuspatial/experimental/detail/ranges/multilinestri…
890e95b 
…ng_range.cuh
@isVoid
making a bit of progress
040e432
@isVoid
fix broken multilinestring->multipoint constructor
7c3603c
@isVoid
Merge branch 'feature/segment_iterators' of github.com:isVoid/cuspati…
5966ad0 
…al into feature/segment_iterators
@isVoid
fix broken multilinestring->multipoint constructor
70ca1b6
@isVoid
passing existing tests
9205533
@isVoid
fix wrong test setup and update docs
4bb3ca3
@isVoid
Merge branch 'feature/segment_iterators' into feature/linestring_poly…
9f34700 
…gon_distance_header
@isVoid
style
8f20feb
@isVoid
Delete point_in_multipolygon.cuh
3ffe5ee
@isVoid
Delete linestring_polygon_distance.hpp
894f870
@isVoid isVoid marked this pull request as ready for review April 10, 2023 16:23
@isVoid isVoid requested review from a team as code owners April 10, 2023 16:23
@isVoid isVoid requested review from vyasr, thomcom, harrism and trxcllnt and removed request for vyasr and harrism April 10, 2023 16:23
@isVoid isVoid added feature request New feature or request non-breaking Non-breaking change labels Apr 10, 2023
harrism
harrism approved these changes Apr 24, 2023
View reviewed changes
Copy link
Member

@harrism harrism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

python/cuspatial/cuspatial/core/spatial/distance.py Outdated Show resolved Hide resolved
@isVoid
Copy link
Contributor Author

isVoid commented Apr 26, 2023

/merge

@rapids-bot rapids-bot bot merged commit 24d29bc into rapidsai:branch-23.06 Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomcom thomcom thomcom approved these changes

@harrism harrism harrism approved these changes

@trxcllnt trxcllnt Awaiting requested review from trxcllnt

Assignees

@isVoid isVoid

Labels
cmake Related to CMake code or build configuration feature request New feature or request libcuspatial Relates to the cuSpatial C++ library non-breaking Non-breaking change Python Related to Python code
Projects
cuSpatial
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python API for pairwise linestring-polygon distance
3 participants
@isVoid @thomcom @harrism