Refactor ST_Distance header only API
#1143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rovement/refactor_st_distance_header
isVoid
added
3 - Ready for Review
harrism
approved these changes
May 29, 2023
|
/merge |
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors
ST_DistanceAPI to reduce the number of kernels to maintain. Currently, each st_distance API maintains its own distance kernel. This refactor let linestring_polygon distance and polygon_polygon distance share the underlying linestring-linestring distance. Also, point-polygon distance now share the same kernel with point-linestring distance kernel.As we are moving to optimization, reducing the total number of kernel to maintain can help scaling the optimization benefit across multiple APIs.
Checklist