Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CUSPATIAL_BUILD_WHEELS and standardize Python builds #1304

Merged
merged 5 commits into from
Dec 6, 2023

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Dec 5, 2023

Description

Some minor simplification in advance of the scikit-build-core migration to better align wheel and non-wheel Python builds. Additionally, this PR simplifies handling of the nvcomp targets and their installation.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Dec 5, 2023
@vyasr vyasr self-assigned this Dec 5, 2023
@vyasr vyasr requested review from a team as code owners December 5, 2023 00:09
@vyasr vyasr requested a review from isVoid December 5, 2023 00:09
@github-actions github-actions bot added cmake Related to CMake code or build configuration Python Related to Python code ci labels Dec 5, 2023
python/cuspatial/CMakeLists.txt Outdated Show resolved Hide resolved
@vyasr
Copy link
Contributor Author

vyasr commented Dec 6, 2023

/merge

@rapids-bot rapids-bot bot merged commit feaf99e into branch-24.02 Dec 6, 2023
61 checks passed
@ajschmidt8 ajschmidt8 deleted the fix/cleanup_python_cmake branch December 6, 2023 20:48
rapids-bot bot pushed a commit that referenced this pull request Feb 2, 2024
This fixes an error introduced in #1304.

Authors:
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - Mark Harris (https://github.com/harrism)
  - Paul Taylor (https://github.com/trxcllnt)
  - Ray Douglass (https://github.com/raydouglass)

URL: #1334
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci cmake Related to CMake code or build configuration improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Related to Python code
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

None yet

4 participants