Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to scikit-build-core #1313

Merged
merged 3 commits into from Dec 13, 2023
Merged

Switch to scikit-build-core #1313

merged 3 commits into from Dec 13, 2023

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Dec 8, 2023 •
edited

Description

Contributes to rapidsai/build-planning#2

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@github-actions github-actions bot added cmake Related to CMake code or build configuration Python Related to Python code ci labels Dec 8, 2023
@vyasr vyasr added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Dec 8, 2023
@github-actions github-actions bot added the conda Related to conda and conda configuration label Dec 8, 2023
@vyasr vyasr changed the title Feat/scikit build core Switch to scikit-build-core Dec 8, 2023
@vyasr vyasr marked this pull request as ready for review December 12, 2023 23:19
@vyasr vyasr requested review from a team as code owners December 12, 2023 23:19
@vyasr vyasr added breaking Breaking change and removed non-breaking Non-breaking change labels Dec 12, 2023
@jarmak-nv jarmak-nv mentioned this pull request Dec 13, 2023
Closed
@vyasr
Copy link
Contributor Author

vyasr commented Dec 13, 2023

/merge

@rapids-bot rapids-bot bot merged commit 60de429 into rapidsai:branch-24.02 Dec 13, 2023
61 checks passed
@vyasr vyasr deleted the feat/scikit_build_core branch December 13, 2023 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harrism harrism harrism approved these changes

@bdice bdice bdice approved these changes

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

@trxcllnt trxcllnt Awaiting requested review from trxcllnt trxcllnt is a code owner automatically assigned from rapidsai/cuspatial-cmake-codeowners

@thomcom thomcom Awaiting requested review from thomcom thomcom is a code owner automatically assigned from rapidsai/cuspatial-python-codeowners

Assignees
No one assigned
Labels
breaking Breaking change ci cmake Related to CMake code or build configuration conda Related to conda and conda configuration improvement Improvement / enhancement to an existing function Python Related to Python code
Projects
cuSpatial
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vyasr @harrism @bdice @ajschmidt8