Fix JOIN_POINT_IN_POLYGON_LARGE_TEST_EXP test
#1346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trxcllnt
force-pushed
the
fix/quadtree-spatial-join-oom
branch
from
7714e40
to
f7c22ac
Compare
trxcllnt
added
improvement
|
Thanks @trxcllnt . Is there an issue already open for this? If not, can you please open one? |
|
@harrism yeah, I think this is the issue @thomcom ran into in #890 (comment). There isn't an issue about the test being incorrect, that was just something I discovered when attempting to fix #890 last night. |
…into fix/quadtree-spatial-join-oom
…into fix/quadtree-spatial-join-oom
trxcllnt
changed the title
quadtree_point_in_polygon OOM on large numbers of input polygonsJOIN_POINT_IN_POLYGON_LARGE_TEST_EXP test
|
/merge |
3 tasks
rapids-bot bot
pushed a commit
that referenced
this pull request
May 24, 2024
) Followup to #1346. * Fixes some typos/omissions in types and CMake. * Adds a new test that OOMs when quadtree_point_in_polygon is passed too many input polygons. * Fixes quadtree spatial join to handle overflow while counting and more conservatively allocate output buffers. Fixes #890. * [Failing test run](https://github.com/rapidsai/cuspatial/actions/runs/8979838628/job/24662981350#step:7:840) * [Passing test run](https://github.com/rapidsai/cuspatial/actions/runs/8981106226/job/24666403165#step:7:840) Authors: - Paul Taylor (https://github.com/trxcllnt) Approvers: - Mark Harris (https://github.com/harrism) - Michael Wang (https://github.com/isVoid) URL: #1381
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
JOIN_POINT_IN_POLYGON_LARGE_TEST_EXPtest isn't returning any points because they aren't evenly distributed.The first commit adds a check to ensure the test fails when no results are returned. The second commit fixes the
JOIN_POINT_IN_POLYGON_LARGE_TEST_EXPtest.Fixes #1380.
Checklist