Skip to content

Commit

Permalink
Replace local copyright check with pre-commit-hooks verify-copyright (#…
Browse files Browse the repository at this point in the history
…48)

The local `copyright.py` script is bug-prone. Replace it with a more robust centralized script from `pre-commit-hooks`.

Issue: rapidsai/build-planning#30

Authors:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

Approvers:
  - Ben Frederickson (https://github.com/benfred)
  - Ray Douglass (https://github.com/raydouglass)

URL: #48
  • Loading branch information
KyleFromNVIDIA committed Mar 18, 2024
1 parent b4e6a9e commit 964f686
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 295 deletions.
22 changes: 16 additions & 6 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -79,12 +79,6 @@ repos:
verbose: true
require_serial: true
exclude: .*/thirdparty/.*
- id: copyright-check
name: copyright-check
entry: python ./ci/checks/copyright.py --git-modified-only --update-current-year
language: python
pass_filenames: false
additional_dependencies: [gitpython]
- id: include-check
name: include-check
entry: python ./cpp/scripts/include_checker.py cpp/bench cpp/include cpp/test
Expand All @@ -107,6 +101,22 @@ repos:
rev: v4.5.0
hooks:
- id: check-json
- repo: https://github.com/rapidsai/pre-commit-hooks
rev: v0.0.1
hooks:
- id: verify-copyright
files: |
(?x)
[.](cmake|cpp|cu|cuh|h|hpp|sh|pxd|py|pyx|rs)$|
CMakeLists[.]txt$|
CMakeLists_standalone[.]txt$|
meta[.]yaml$|
setup[.]cfg$
exclude: |
(?x)
cpp/include/cuvs/neighbors/detail/faiss_select/|
docs/source/sphinxext/github_link\.py|
cpp/cmake/modules/FindAVX\.cmake|
default_language_version:
python: python3
289 changes: 0 additions & 289 deletions ci/checks/copyright.py

This file was deleted.

0 comments on commit 964f686

Please sign in to comment.