-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy new copyright update script to all RAPIDS repos #30
Comments
The local copyright.py script is bug-prone. Replace it with a more robust centralized script from pre-commit-hooks. Issue: rapidsai/build-planning#30
List of repos needing this: https://github.com/search?q=org%3Arapidsai%20copyright.py&type=code
|
The local copyright.py script is bug-prone. Replace it with a more robust centralized script from pre-commit-hooks. Issue: rapidsai/build-planning#30
The local copyright.py script is bug-prone. Replace it with a more robust centralized script from pre-commit-hooks. Issue: rapidsai/build-planning#30
…5732) The local `copyright.py` script is bug-prone. Replace it with a more robust centralized script from `pre-commit-hooks`. Issue: rapidsai/build-planning#30 Authors: - Kyle Edwards (https://github.com/KyleFromNVIDIA) Approvers: - Jake Awe (https://github.com/AyodeAwe) - Bradley Dice (https://github.com/bdice) URL: #5732
The local copyright.py script is bug-prone. Replace it with a more robust centralized script from pre-commit-hooks. Issue: rapidsai/build-planning#30
The local copyright.py script is bug-prone. Replace it with a more robust centralized script from pre-commit-hooks. Issue: rapidsai/build-planning#30
…144) The local `copyright.py` script is bug-prone. Replace it with a more robust centralized script from `pre-commit-hooks`. Issue: rapidsai/build-planning#30 Authors: - Kyle Edwards (https://github.com/KyleFromNVIDIA) Approvers: - Brad Rees (https://github.com/BradReesWork) - Jake Awe (https://github.com/AyodeAwe) URL: #144
…352) The local `copyright.py` script is bug-prone. Replace it with a more robust centralized script from `pre-commit-hooks`. Issue: rapidsai/build-planning#30 Authors: - Kyle Edwards (https://github.com/KyleFromNVIDIA) Approvers: - Mads R. B. Kristensen (https://github.com/madsbk) - Ray Douglass (https://github.com/raydouglass) URL: #352
…2220) The local `copyright.py` script is bug-prone. Replace it with a more robust centralized script from `pre-commit-hooks`. Issue: rapidsai/build-planning#30 Authors: - Kyle Edwards (https://github.com/KyleFromNVIDIA) Approvers: - Jake Awe (https://github.com/AyodeAwe) URL: #2220
…556) The local `copyright.py` script is bug-prone. Replace it with a more robust centralized script from `pre-commit-hooks`. Issue: rapidsai/build-planning#30 Authors: - Kyle Edwards (https://github.com/KyleFromNVIDIA) Approvers: - Jake Awe (https://github.com/AyodeAwe) URL: #556
…48) The local `copyright.py` script is bug-prone. Replace it with a more robust centralized script from `pre-commit-hooks`. Issue: rapidsai/build-planning#30 Authors: - Kyle Edwards (https://github.com/KyleFromNVIDIA) Approvers: - Ben Frederickson (https://github.com/benfred) - Ray Douglass (https://github.com/raydouglass) URL: #48
If we are modifying/adding a file that has vendored code e.g. ( |
My understanding is that |
I’ll point you both to a resource about this offline. @KyleFromNVIDIA There are a few references to copyright.py in developer guides for cuml and raft (possibly more). Just be aware to check for that too. They can be removed or updated for the pre-commit hook. |
…apidsai#48) The local `copyright.py` script is bug-prone. Replace it with a more robust centralized script from `pre-commit-hooks`. Issue: rapidsai/build-planning#30 Authors: - Kyle Edwards (https://github.com/KyleFromNVIDIA) Approvers: - Ben Frederickson (https://github.com/benfred) - Ray Douglass (https://github.com/raydouglass) URL: rapidsai#48
…apidsai#48) The local `copyright.py` script is bug-prone. Replace it with a more robust centralized script from `pre-commit-hooks`. Issue: rapidsai/build-planning#30 Authors: - Kyle Edwards (https://github.com/KyleFromNVIDIA) Approvers: - Ben Frederickson (https://github.com/benfred) - Ray Douglass (https://github.com/raydouglass) URL: rapidsai#48
It looks like we still have some clean to do here before we can close.
References can be seen in this search: https://github.com/search?q=org%3Arapidsai%20copyright.py&type=code |
rapidsai/wholegraph#149 removes the extra copyright script. I'll take a look at the others. |
Issue: rapidsai/build-planning#30 Authors: - Kyle Edwards (https://github.com/KyleFromNVIDIA) Approvers: - Ben Frederickson (https://github.com/benfred) URL: #81
Issue: rapidsai/build-planning#30 Authors: - Kyle Edwards (https://github.com/KyleFromNVIDIA) Approvers: - Bradley Dice (https://github.com/bdice) URL: #5848
Issue: rapidsai/build-planning#30 Authors: - Kyle Edwards (https://github.com/KyleFromNVIDIA) Approvers: - Bradley Dice (https://github.com/bdice) - Jake Awe (https://github.com/AyodeAwe) URL: #2266
Contributes to rapidsai/build-planning#30. Proposes adding the RAPIDS `verify-copyright` pre-commit hook, which automatically updates copyright dates for modified files. This also fixes one date in a file from #1529. Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Bradley Dice (https://github.com/bdice) - Kyle Edwards (https://github.com/KyleFromNVIDIA) URL: #1553
…(#48) The local `copyright.py` script is bug-prone. Replace it with a more robust centralized script from `pre-commit-hooks`. Issue: rapidsai/build-planning#30 Authors: - Kyle Edwards (https://github.com/KyleFromNVIDIA) Approvers: - Ben Frederickson (https://github.com/benfred) - Ray Douglass (https://github.com/raydouglass) URL: rapidsai/cuvs#48
Issue: rapidsai/build-planning#30 Authors: - Kyle Edwards (https://github.com/KyleFromNVIDIA) Approvers: - Ben Frederickson (https://github.com/benfred) URL: rapidsai/cuvs#81
A new copyright update script was added to https://github.com/rapidsai/pre-commit-hooks, and
v0.0.1
was tagged. This check has been deployed in cudf and cuspatial and seems to be working very well. We should deploy this to the rest of RAPIDS too.The text was updated successfully, but these errors were encountered: