Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept host_mdspan for IVF-PQ build and extend #148

Merged
merged 6 commits into from
May 28, 2024
Merged

Accept host_mdspan for IVF-PQ build and extend #148

merged 6 commits into from
May 28, 2024

Conversation

tfeher
Copy link
Contributor

@tfeher tfeher commented May 23, 2024 •
edited

This PR enables host input arrays for ivf_pq::build and ivf_pq::extend.

closes #120
closes #143

@tfeher tfeher self-assigned this May 23, 2024
@github-actions github-actions bot added the cpp label May 23, 2024
@tfeher tfeher marked this pull request as ready for review May 24, 2024 13:58
@tfeher tfeher requested a review from a team as a code owner May 24, 2024 13:58
@cjnolet cjnolet added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels May 24, 2024
@tfeher tfeher mentioned this pull request May 28, 2024
Open
10 tasks
@cjnolet
Copy link
Member

cjnolet commented May 28, 2024

/merge

@rapids-bot rapids-bot bot merged commit 1912355 into rapidsai:branch-24.06 May 28, 2024
56 of 57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnolet cjnolet cjnolet approved these changes

Assignees

@tfeher tfeher

Labels
cpp improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
VS/ML/DM Primitives Release Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] consistent serialization API [BUG] IVF-PQ build / extend API does not support host mdspan
2 participants
@tfeher @cjnolet