Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] IVF-PQ build / extend API does not support host mdspan #120

Closed
tfeher opened this issue May 15, 2024 · 0 comments · Fixed by #148
Closed

[BUG] IVF-PQ build / extend API does not support host mdspan #120

tfeher opened this issue May 15, 2024 · 0 comments · Fixed by #148
Assignees
@tfeher
Labels
bug Something isn't working

Comments

@tfeher
Copy link
Contributor

tfeher commented May 15, 2024

The pointer based APIs in RAFT for ivf_pq::build and ivf_pq::extend do accept host and device arrays (as well es pinned, and managed arrays). Accepting host arrays is an important feature: IVF-PQ algorithm allows us to build index from dataset that is larger than GPU memory (it can be even larger than host memory, if the data is mmap-ed). The cuVS interface should also support host arrays.
@tfeher tfeher added the bug Something isn't working label May 15, 2024
@tfeher tfeher changed the title [BUG] IVF-PQ build / extend API only supports host mdarray [BUG] IVF-PQ build / extend API does not support host mdspan May 16, 2024
@tfeher tfeher self-assigned this May 23, 2024
@tfeher tfeher mentioned this issue May 23, 2024
Merged
@rapids-bot rapids-bot bot closed this as completed in #148 May 28, 2024
rapids-bot bot pushed a commit that referenced this issue May 28, 2024
@tfeher
Accept host_mdspan for IVF-PQ build and extend (#148)
1912355 
This PR enables host input arrays for `ivf_pq::build` and `ivf_pq::extend`.

closes #120 
closes #143

Authors:
  - Tamas Bela Feher (https://github.com/tfeher)
  - Corey J. Nolet (https://github.com/cjnolet)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)

URL: #148
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tfeher tfeher

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Accept host_mdspan for IVF-PQ build and extend tfeher/cuvs
1 participant
@tfeher