-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove librmm docs #517
Remove librmm docs #517
Conversation
✅ Deploy Preview for docs-rapids-ai ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need a solution for libcudf's docs that currently depend on librmm's Doxygen docs.
After some internal discussions, this does need to be addressed, but we don't want to block updating to the |
Following up: rapidsai/rmm#1604 re-adds librmm docs. From discussion with @raydouglass, we don't need to link to them publicly on docs.rapids.ai, as they are already included in the rmm docs (both C++ and Python). The librmm docs will just be used to cross-reference from libcudf docs. |
This reverts commit 77b5500. See: rapidsai/docs#517 (review) We need to have librmm docs published in order to enable cross-linking of librmm from libcudf docs. From discussion with @raydouglass, we don't need to link to them publicly on docs.rapids.ai, as they are already included in the rmm docs (both C++ and Python). The librmm docs will just be used to cross-reference from libcudf docs. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Ray Douglass (https://github.com/raydouglass) - Vyas Ramasubramani (https://github.com/vyasr) URL: #1604
librmm
docs were merged intormm
docs and24.02
was the last version to have separatedlibrmm
docs.Now that the legacy version is
24.04
, thelibrmm
docs can be removed.Ref: #478
https://github.com/rapidsai/docs/actions/runs/9421083274/job/25954311807