Remove librmm docs #517
Merged
Remove librmm docs #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rapids-ai ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
bdice
previously requested changes
Jun 7, 2024
ajschmidt8
approved these changes
Jun 7, 2024
After some internal discussions, this does need to be addressed, but we don't want to block updating to the |
3 tasks
|
Following up: rapidsai/rmm#1604 re-adds librmm docs. From discussion with @raydouglass, we don't need to link to them publicly on docs.rapids.ai, as they are already included in the rmm docs (both C++ and Python). The librmm docs will just be used to cross-reference from libcudf docs. |
rapids-bot bot
pushed a commit
to rapidsai/rmm
that referenced
this pull request
Jul 15, 2024
This reverts commit 77b5500. See: rapidsai/docs#517 (review) We need to have librmm docs published in order to enable cross-linking of librmm from libcudf docs. From discussion with @raydouglass, we don't need to link to them publicly on docs.rapids.ai, as they are already included in the rmm docs (both C++ and Python). The librmm docs will just be used to cross-reference from libcudf docs. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Ray Douglass (https://github.com/raydouglass) - Vyas Ramasubramani (https://github.com/vyasr) URL: #1604
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
librmmdocs were merged intormmdocs and24.02was the last version to have separatedlibrmmdocs.Now that the legacy version is
24.04, thelibrmmdocs can be removed.Ref: #478
https://github.com/rapidsai/docs/actions/runs/9421083274/job/25954311807