Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Update instructions for configuring/running blazingsql queries #4

Merged
merged 3 commits into from
May 14, 2020

Conversation

ayushdg
Copy link
Member

@ayushdg ayushdg commented May 13, 2020

This PR updates the README instructions to include cluster configuration and environment variables required for running the blazingsql version of the queries.

Copy link
Member Author

@ayushdg ayushdg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments. Happy for inputs/thoughts on this structure vs TCP only section in the Cluster-Configurations section above.

Caveat is that blazing doesn't require most of the other Dask-configuration variables so it seemed to fit into this section.

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Member

@beckernick beckernick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested changes look good to me. Made a small update

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@ayushdg ayushdg marked this pull request as ready for review May 14, 2020 00:54
@ayushdg ayushdg changed the title [WIP] Update instructions for configuring/running blazingsql queries [REVIEW] Update instructions for configuring/running blazingsql queries May 14, 2020
Copy link
Member

@beckernick beckernick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. Thanks for the great work on this

@beckernick beckernick merged commit 827e313 into rapidsai:master May 14, 2020
VibhuJawa pushed a commit to VibhuJawa/gpu-bdb that referenced this pull request Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants