-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW] Update instructions for configuring/running blazingsql queries #4
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some comments. Happy for inputs/thoughts on this structure vs TCP only section in the Cluster-Configurations
section above.
Caveat is that blazing doesn't require most of the other Dask-configuration variables so it seemed to fit into this section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested changes look good to me. Made a small update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM. Thanks for the great work on this
Fix Q29 OOM issue
This PR updates the README instructions to include cluster configuration and environment variables required for running the blazingsql version of the queries.