Skip to content

Commit

Permalink
Remove supports_streams from custom RAFT memory resources (#2121)
Browse files Browse the repository at this point in the history
Part of rapidsai/rmm#1389. This removes now-optional and soon-to-be deprecated `supports_streams()` from RAFT's custom `device_memory_resource` implementations.

Authors:
  - Mark Harris (https://github.com/harrism)
  - Corey J. Nolet (https://github.com/cjnolet)

Approvers:
  - Michael Schellenberger Costa (https://github.com/miscco)
  - Corey J. Nolet (https://github.com/cjnolet)

URL: #2121
  • Loading branch information
harrism committed Feb 1, 2024
1 parent e407677 commit 3c87b92
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 16 deletions.
8 changes: 0 additions & 8 deletions cpp/bench/ann/src/common/cuda_huge_page_resource.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -41,14 +41,6 @@ class cuda_huge_page_resource final : public rmm::mr::device_memory_resource {
cuda_huge_page_resource& operator=(cuda_huge_page_resource const&) = default;
cuda_huge_page_resource& operator=(cuda_huge_page_resource&&) = default;

/**
* @brief Query whether the resource supports use of non-null CUDA streams for
* allocation/deallocation. `cuda_huge_page_resource` does not support streams.
*
* @returns bool false
*/
[[nodiscard]] bool supports_streams() const noexcept override { return false; }

private:
/**
* @brief Allocates memory of size at least `bytes` using cudaMalloc.
Expand Down
8 changes: 0 additions & 8 deletions cpp/bench/ann/src/common/cuda_pinned_resource.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -45,14 +45,6 @@ class cuda_pinned_resource final : public rmm::mr::device_memory_resource {
cuda_pinned_resource& operator=(cuda_pinned_resource const&) = default;
cuda_pinned_resource& operator=(cuda_pinned_resource&&) = default;

/**
* @brief Query whether the resource supports use of non-null CUDA streams for
* allocation/deallocation. `cuda_pinned_resource` does not support streams.
*
* @returns bool false
*/
[[nodiscard]] bool supports_streams() const noexcept override { return false; }

private:
/**
* @brief Allocates memory of size at least `bytes` using cudaMalloc.
Expand Down

0 comments on commit 3c87b92

Please sign in to comment.