Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace device_memory_resource* with device_async_resource_ref #2261

Closed
Tracked by #16
, #1443
...
harrism opened this issue Apr 10, 2024 · 0 comments · Fixed by #2269
Closed
Tracked by #16
, #1443
...

Replace device_memory_resource* with device_async_resource_ref #2261

harrism opened this issue Apr 10, 2024 · 0 comments · Fixed by #2269
Labels
improvement Improvement / enhancement to an existing function

Comments

@harrism
Copy link
Member

harrism commented Apr 10, 2024

Update occurences of rmm::mr::device_memory_resource* to
rmm::device_async_resource_ref in this repo. The rationale is explained
in this document.
@harrism harrism added the improvement Improvement / enhancement to an existing function label Apr 10, 2024
This was referenced Apr 17, 2024
Merged
Open
Open
rapids-bot bot pushed a commit that referenced this issue Apr 24, 2024
@harrism
Convert device_memory_resource* to device_async_resource_ref (#2269)
71a19a2 
Closes #2261

For reviewers:
Many of changes are simple textual replace of `rmm::mr::device_memory_resource *` with `rmm::device_async_resource_ref`.  However there are several places where RAFT used a default value of `nullptr` for `device_memory_resource*` parameters. This is incompatible with a `resource_ref`, which is a lightweight non-owning reference class, not a pointer. In most places, I was able to either remove the default parameter value, or use `rmm::mr::get_current_device_resource()`. In the case of ivf_pq, I removed the deprecated versions of `search` that took an `mr` parameter.

I removed the unused old src/util/memory_pool.cpp and its headers.

Authors:
  - Mark Harris (https://github.com/harrism)

Approvers:
  - Artem M. Chirkin (https://github.com/achirkin)
  - Dante Gama Dessavre (https://github.com/dantegd)
  - Corey J. Nolet (https://github.com/cjnolet)

URL: #2269
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function
Projects
RMM Project Board
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Convert device_memory_resource* to device_async_resource_ref harrism/raft
1 participant
@harrism