Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated headers #1145

Merged
merged 14 commits into from
Feb 13, 2023
Merged

Conversation

lowener
Copy link
Contributor

@lowener lowener commented Jan 16, 2023

Related to #555
The previous PR (#1041) was too old and impacted too many files. This one is simpler and address most of the deprecated files.

@lowener lowener added improvement Improvement / enhancement to an existing function breaking Breaking change cpp labels Jan 16, 2023
@lowener lowener requested a review from a team as a code owner January 16, 2023 17:41
@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2023

Codecov Report

❗ No coverage uploaded for pull request base (branch-23.04@16746ee). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff               @@
##             branch-23.04    #1145   +/-   ##
===============================================
  Coverage                ?   87.99%           
===============================================
  Files                   ?       21           
  Lines                   ?      483           
  Branches                ?        0           
===============================================
  Hits                    ?      425           
  Misses                  ?       58           
  Partials                ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

rapids-bot bot pushed a commit to rapidsai/cuml that referenced this pull request Jan 31, 2023
@lowener lowener requested review from a team as code owners February 6, 2023 18:10
@lowener lowener changed the base branch from branch-23.02 to branch-23.04 February 6, 2023 18:12
@github-actions github-actions bot removed the CMake label Feb 6, 2023
This reverts commit bd0d86b.
@lowener lowener removed request for a team February 6, 2023 18:22
@github-actions github-actions bot removed the ci label Feb 12, 2023
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cjnolet
Copy link
Member

cjnolet commented Feb 13, 2023

/merge

@rapids-bot rapids-bot bot merged commit 2347e06 into rapidsai:branch-23.04 Feb 13, 2023
@lowener lowener deleted the 23.02-rm-depr branch February 14, 2023 10:33
jakirkham pushed a commit to jakirkham/cuml that referenced this pull request Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change cpp improvement Improvement / enhancement to an existing function
Projects
Development

Successfully merging this pull request may close these issues.

3 participants