Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve logging #673

Merged
merged 3 commits into from
May 24, 2022
Merged

Improve logging #673

merged 3 commits into from
May 24, 2022

Conversation

achirkin
Copy link
Contributor

A few fixes/improvements to the logger:

  • Removed one of the two duplicate versions (common/detail/logger.hpp)
  • Added RAFT_LOG_TRACE_VEC to trace device/host arrays
  • Added inline annotations to some of the helper functions (to fix the linker error)
  • Replaced char[] with vector<char> where applicable for safety and to address clang-tidy warnings
  • Changed the default logger level to be controlled by the macro RAFT_ACTIVE_LEVEL instead of the fixed RAFT_LEVEL_INFO, but set the default RAFT_ACTIVE_LEVEL to RAFT_LEVEL_INFO.

@achirkin achirkin requested a review from a team as a code owner May 24, 2022 07:00
@github-actions github-actions bot added the cpp label May 24, 2022
@achirkin achirkin added 3 - Ready for Review improvement Improvement / enhancement to an existing function non-breaking Non-breaking change and removed cpp labels May 24, 2022
@github-actions github-actions bot added the cpp label May 24, 2022
lowener
lowener approved these changes May 24, 2022
View reviewed changes
Copy link
Contributor

@lowener lowener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement. I'm also linking #667 that I opened yesterday for the logger compilation issue.

cpp/include/raft/common/detail/logger.hpp Outdated Show resolved Hide resolved
tfeher
tfeher approved these changes May 24, 2022
View reviewed changes
Copy link
Contributor

@tfeher tfeher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Artem for the PR, it looks good to me.

@cjnolet
Copy link
Member

cjnolet commented May 24, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 46eb171 into rapidsai:branch-22.06 May 24, 2022
@lowener lowener mentioned this pull request May 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lowener lowener lowener approved these changes

@cjnolet cjnolet cjnolet approved these changes

@tfeher tfeher tfeher approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review cpp improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@achirkin @cjnolet @tfeher @lowener