[REVIEW] mdspanify raft::random functions uniformInt, normalTable, fill, bernoulli, and scaled_bernoulli #897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and a unit test for it.
and a unit test for it.
There's no unit test specifically for this function, but it is used in the normalTable test, so I've made the mdspan version of the normalTable test call this function.
mhoemmen
changed the title
mhoemmen
added
feature request
mhoemmen
changed the title
cjnolet
reviewed
Oct 5, 2022
cjnolet
approved these changes
Oct 5, 2022
This touches a test file changed by PR rapidsai#802, but this commit should not conflict with that PR.
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add mdspan overloads of
raft::randomfunctionsuniformInt,normalInt,normalTable,fill,bernoulli, andscaled_bernoulli. ImprovenormalTabledocumentation to explain that the output table has a row-major layout.This is rebased atop PR #896, which I've since closed.
This should complete all the
raft::randommdspan overloads.