Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify using RMM with other Python libraries #1034

Merged
merged 4 commits into from
May 17, 2022

Conversation

jrhemstad
Copy link
Contributor

Based on an internal question, clarified the README docs on what the APIs for enabling cuPy/Numba to use RMM simply inherit whatever the state of RMM is as opposed to modify the state (like enabling a memory pool).

Based on an internal question, clarified the README docs on what the APIs for enabling cuPy/Numba to use RMM simply inherit whatever the state of RMM is as opposed to modify the state (like enabling a memory pool).
@jrhemstad jrhemstad added doc Documentation non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels May 11, 2022
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a helpful clarification. 👍

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@bdice bdice removed the improvement Improvement / enhancement to an existing function label May 11, 2022
@bdice bdice added this to PR-WIP in v22.06 Release via automation May 11, 2022
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
Copy link
Member

@harrism harrism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple nits.

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
v22.06 Release automation moved this from PR-WIP to PR-Needs review May 11, 2022
jrhemstad and others added 2 commits May 11, 2022 21:30
Co-authored-by: Mark Harris <mharris@nvidia.com>
Co-authored-by: Mark Harris <mharris@nvidia.com>
v22.06 Release automation moved this from PR-Needs review to PR-Reviewer approved May 17, 2022
@harrism
Copy link
Member

harrism commented May 17, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 94d95be into branch-22.06 May 17, 2022
v22.06 Release automation moved this from PR-Reviewer approved to Done May 17, 2022
@jakirkham jakirkham deleted the jrhemstad-patch-1 branch May 17, 2022 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Documentation non-breaking Non-breaking change
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants