Properly handle cudaMemHandleTypeNone and cudaErrorInvalidValue in is_export_handle_type_supported #1055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes rapidsai#1054 Signed-off-by: Gera Shegalov <gera@apache.org>
rongou
approved these changes
Jun 1, 2022
Signed-off-by: Gera Shegalov <gera@apache.org>
harrism
requested changes
Jun 1, 2022
@harrism review Co-authored-by: Mark Harris <mharris@nvidia.com>
Signed-off-by: Gera Shegalov <gera@apache.org>
gerashegalov
changed the title
harrism
approved these changes
Jun 1, 2022
|
@gerashegalov please confirm this fixes #1054 before we merge. Thanks! |
|
just saw the internal thread, looks good to target 22.08 |
gerashegalov
added a commit
to gerashegalov/cudf
that referenced
this pull request
Jun 2, 2022
Signed-off-by: Gera Shegalov <gera@apache.org>
@harrism the fix has been confirmed with https://github.com/rapidsai/cudf/compare/branch-22.08...gerashegalov:rmmTest?expand=1#diff-707bbf4bad4194f1803f3586af0611546f6064a20561f68e34f74f30d2ec4f55L20-R27 |
|
@gpucibot merge |
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cudaErrorInvalidValuereturned fromcudaDeviceGetAttributeto returnfalsefromis_export_handle_type_supportedcudaMemHandleTypeNoneCo-authored-by: @jrhemstad
Co-authored-by: @harrism
Closes #1054
Signed-off-by: Gera Shegalov gera@apache.org