Support using THRUST_WRAPPED_NAMESPACE #1077
Conversation
robertmaynard
added
feature request
harrism
changed the title
include/rmm/device_vector.hpp
Outdated
| #ifdef THRUST_WRAPPED_NAMESPACE | ||
| using namespace THRUST_WRAPPED_NAMESPACE; | ||
| #endif |
There was a problem hiding this comment.
For simplicity and tidiness, could these 3 lines just be put in a header that all RMM headers include?
There was a problem hiding this comment.
How did you choose which headers to put this in? Is it needed in the ones that do not use Thrust like cuda_async_memory_resource.hpp?
If it is needed everywhere, you could put it in the base MR header (device_memory_resource.hpp) then all MR headers would include it.
There was a problem hiding this comment.
This logic only needs to be placed in headers that explicitly include thrust headers.
Given that rmm has 8 headers that include thrust, refactoring to a common header seems wise.
There was a problem hiding this comment.
I have updated the pr to move the shared logic to thrust_namespace.h
|
This PR has been labeled |
robertmaynard
force-pushed
the
support_custom_thrust_namespaces
branch
from
46b2835
to
ebe9f11
Compare
robertmaynard
added
3 - Ready for review
|
@gpucibot merge |
Allows rmm to be used in the presence of
THRUST_WRAPPED_NAMESPACEwhich changes the namespace location of all thrust types.