Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pre-commit hooks #1154

Merged
merged 10 commits into from
Dec 14, 2022
Merged

Update pre-commit hooks #1154

merged 10 commits into from
Dec 14, 2022

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Nov 9, 2022 •
edited
Loading

Description

This PR updates rmm's pre-commit hooks and CI style check scripts.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@bdice bdice self-assigned this Nov 9, 2022
@github-actions github-actions bot added ci CMake Python Related to RMM Python API labels Nov 9, 2022
@bdice bdice added 0 - Blocked Cannot progress due to external reasons tech debt debt Internal clean up and improvements to reduce maintenance and technical debt in general non-breaking Non-breaking change improvement Improvement / enhancement to an existing function and removed CMake Python Related to RMM Python API ci labels Nov 9, 2022
@harrism
Copy link
Member

harrism commented Nov 9, 2022

Burn down starts tomorrow, so if you want to get part of this in 22.12 suggest opening the PRs now.

@bdice
Copy link
Contributor Author

bdice commented Nov 10, 2022

@harrism It's not as time sensitive as GitHub Actions for cuDF, which is my primary project at the moment. Since this is partially blocked by #1151 anyway, I am going to de-prioritize this and come back to it at a convenient time (probably just after burndown, targeting 23.02). Since it's mostly for developer convenience, the release timing is not crucial.

@bdice bdice changed the base branch from branch-22.12 to branch-23.02 December 7, 2022 19:13
@github-actions github-actions bot added ci CMake Python Related to RMM Python API labels Dec 7, 2022
@github-actions github-actions bot added the conda label Dec 7, 2022
@bdice bdice marked this pull request as ready for review December 7, 2022 19:19
@bdice bdice requested a review from a team as a code owner December 7, 2022 19:19
@bdice bdice requested review from a team as code owners December 7, 2022 19:19
@bdice bdice mentioned this pull request Dec 7, 2022
Merged
3 tasks
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-23.02@4d1dee1). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files 
@@              Coverage Diff               @@
##             branch-23.02   #1154   +/-   ##
==============================================
  Coverage                ?   0.00%           
==============================================
  Files                   ?       5           
  Lines                   ?     406           
  Branches                ?       0           
==============================================
  Hits                    ?       0           
  Misses                  ?     406           
  Partials                ?       0

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

ajschmidt8
ajschmidt8 requested changes Dec 7, 2022
View reviewed changes
ci/check_style.sh Outdated Show resolved Hide resolved
@bdice bdice requested a review from ajschmidt8 December 8, 2022 00:17
@bdice bdice removed the 0 - Blocked Cannot progress due to external reasons label Dec 8, 2022
@bdice
Copy link
Contributor Author

bdice commented Dec 13, 2022 •
edited
Loading

@harrism @raydouglass @ajschmidt8 This needs re-approved to be merged. It was in a draft state the first time that some approvals were granted (and I applied the requested change from AJ).

edit: Actually we don't need re-approval from Ray. Just AJ, since he requested changes.

@bdice
Copy link
Contributor Author

bdice commented Dec 14, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit c5c02fc into rapidsai:branch-23.02 Dec 14, 2022
shwina pushed a commit to shwina/rmm that referenced this pull request Dec 19, 2022
@bdice @shwina
Update pre-commit hooks (rapidsai#1154)
cde2d8a 
This PR updates rmm's pre-commit hooks and CI style check scripts.

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Mark Harris (https://github.com/harrism)
  - Ray Douglass (https://github.com/raydouglass)
  - AJ Schmidt (https://github.com/ajschmidt8)

URL: rapidsai#1154
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harrism harrism harrism approved these changes

@raydouglass raydouglass raydouglass approved these changes

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

Assignees

@bdice bdice

Labels
ci CMake conda improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Related to RMM Python API tech debt debt Internal clean up and improvements to reduce maintenance and technical debt in general
Projects
RMM Project Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bdice @harrism @codecov-commenter @raydouglass @ajschmidt8