Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.10. #1166

Merged
merged 1 commit into from
Jan 5, 2023
Merged

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Nov 21, 2022

Description

This PR adds support for Python 3.10.

This set of changes aligns with the behavior I'd like to see across RAPIDS for the Python version changes described in RAPIDS Support Notice (RSN) 22 and 23. rapidsai/docs#310

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@bdice bdice requested a review from a team as a code owner November 21, 2022 21:37
@github-actions github-actions bot added the Python Related to RMM Python API label Nov 21, 2022
@bdice bdice requested a review from a team as a code owner November 21, 2022 22:51
@github-actions github-actions bot added the conda label Nov 21, 2022
@bdice bdice added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Nov 21, 2022
@vyasr
Copy link
Contributor

vyasr commented Nov 23, 2022

Should we be waiting to do this in lockstep across all of RAPIDS?

@bdice
Copy link
Contributor Author

bdice commented Nov 24, 2022

Should we be waiting to do this in lockstep across all of RAPIDS?

Moving in lockstep is my intention as well, this is meant to be a template for how that move should occur across the rest of RAPIDS. There are a few changes that will happen all very quickly (mostly after finishing the GitHub Actions migration but before 23.02 is very far in development): RSNs announce support for Python 3.10 in 23.02, CI images and CI matrix jobs will be updated, and packages will need changes in their code (like setup.py). We don’t want to be in a situation where CI wants to run Python 3.10 jobs but packages cannot be built or installed because of hard limits like python_requires=">=3.8,<3.10", so enabling support for packages (like this PR) should happen first. We also want to avoid a situation we have had for various packages in the past where packages’ claimed version support was misaligned with RSNs / CI (version support in setup.py was not updated when the support matrix updated).

@vyasr
Copy link
Contributor

vyasr commented Nov 29, 2022

Sounds good. I'll mark this PR as Do Not Merge for now so that nobody else accidentally merges prematurely, but feel free to remove when you are ready with the other repos.

@vyasr vyasr added the 5 - DO NOT MERGE Hold off on merging; see PR for details label Nov 29, 2022
@github-actions github-actions bot removed the conda label Jan 5, 2023
@bdice bdice removed the request for review from a team January 5, 2023 22:03
@bdice bdice removed the 5 - DO NOT MERGE Hold off on merging; see PR for details label Jan 5, 2023
@bdice
Copy link
Contributor Author

bdice commented Jan 5, 2023

This PR's original contents were largely superseded by #1184 -- the changes are now trivial so I'll merge this as-is.

@bdice bdice self-assigned this Jan 5, 2023
@bdice
Copy link
Contributor Author

bdice commented Jan 5, 2023

/merge

@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2023

Codecov Report

Base: 0.00% // Head: 0.00% // No change to project coverage 👍

Coverage data is based on head (a1cc47f) compared to base (7fb45d4).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##           branch-23.02   #1166   +/-   ##
============================================
  Coverage          0.00%   0.00%           
============================================
  Files                 6       6           
  Lines               414     421    +7     
============================================
- Misses              414     421    +7     
Impacted Files Coverage Δ
python/rmm/__init__.py 0.00% <ø> (ø)
python/rmm/rmm.py 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rapids-bot rapids-bot bot merged commit 0c16507 into rapidsai:branch-23.02 Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Related to RMM Python API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants