Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codespell as a linter #1231

Merged
merged 2 commits into from
Mar 14, 2023
Merged

Add codespell as a linter #1231

merged 2 commits into from
Mar 14, 2023

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Mar 14, 2023

Description

Following the example of rapidsai/cudf#12097, this PR adds codespell as a linter for rmm.

Note: I have not included a section in the CONTRIBUTING.md about how to use this (as was done in cudf's PR) because I plan to overhaul the contributing guides for all RAPIDS repos in the near term, and have a single source in docs.rapids.ai with common information about linters used in RAPIDS.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@bdice bdice requested a review from a team as a code owner March 14, 2023 04:29
@bdice bdice requested review from rongou and codereport March 14, 2023 04:29
@bdice bdice self-assigned this Mar 14, 2023
@bdice bdice added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Mar 14, 2023
@github-actions github-actions bot added the cpp Pertains to C++ code label Mar 14, 2023
Copy link
Member

@benfred benfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - thanks!

@bdice
Copy link
Contributor Author

bdice commented Mar 14, 2023

/merge

@rapids-bot rapids-bot bot merged commit 663a9b0 into rapidsai:branch-23.04 Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cpp Pertains to C++ code improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants