Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require Numba 0.57.0+ & NumPy 1.21.0+ #1279

Merged
merged 1 commit into from
May 31, 2023
Merged

Require Numba 0.57.0+ & NumPy 1.21.0+ #1279

merged 1 commit into from
May 31, 2023

Conversation

jakirkham
Copy link
Member

Align with the rest of RAPIDS on these requirements. Also needed for CUDA 12 support.

Description

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@jakirkham jakirkham requested review from a team as code owners May 30, 2023 22:37
@github-actions github-actions bot added conda Python Related to RMM Python API labels May 30, 2023
@jakirkham jakirkham added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels May 30, 2023
@jakirkham
Require Numba 0.57.0+ & NumPy 1.21.0+
d55104e 
Align with the rest of RAPIDS on these requirements. Also needed for
CUDA 12 support.
bdice
bdice approved these changes May 30, 2023
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. This is also needed for CUDA 12 in #1207, so good to get the changes in separately.

@bdice
Copy link
Contributor

bdice commented May 30, 2023 •
edited
Loading

@jakirkham This could target 23.08, I think? I don't think it's essential for 23.06.

edit: We are shipping CUDA 12 wheels in 23.06, so I take that back. This should target 23.06.

@jakirkham
Copy link
Member Author

Wouldn't we want these for the wheels?

@raydouglass raydouglass merged commit ec67953 into rapidsai:branch-23.06 May 31, 2023
40 of 41 checks passed
@jakirkham jakirkham deleted the req_numba_57 branch May 31, 2023 17:02
@jakirkham
Copy link
Member Author

Thanks all! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harrism harrism harrism approved these changes

@raydouglass raydouglass raydouglass approved these changes

@bdice bdice bdice approved these changes

Assignees
No one assigned
Labels
conda improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Related to RMM Python API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jakirkham @bdice @harrism @raydouglass