Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use gbench thread_index() accessor to fix replay bench compilation #1293

Merged

Conversation

harrism
Copy link
Member

@harrism harrism commented Jun 12, 2023

Description

rapidsai/rapids-cmake#425 updated the google benchmark version to a version that is more than 2 years newer, and the API changed. This PR just changes to use an accessor rather than a public (now private) data member to fix the compilation errors.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@harrism harrism requested a review from a team as a code owner June 12, 2023 22:55
@harrism harrism requested review from rongou and bdice June 12, 2023 22:55
@harrism harrism self-assigned this Jun 12, 2023
@harrism harrism added 3 - Ready for review Ready for review by team bug Something isn't working non-breaking Non-breaking change labels Jun 12, 2023
@harrism
Copy link
Member Author

harrism commented Jun 13, 2023

For some reason CI isn't running...

@harrism
Copy link
Member Author

harrism commented Jun 13, 2023

/merge

@rapids-bot rapids-bot bot merged commit ea50f90 into rapidsai:branch-23.08 Jun 13, 2023
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for review Ready for review by team bug Something isn't working non-breaking Non-breaking change
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants