Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a missing '#include <array>' in logger.hpp #1295

Merged
merged 1 commit into from
Jun 20, 2023

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Jun 20, 2023

For std::array units{...}.

Cropped up in conan-io/conan-center-index#17671.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

For `std::array units{...}`.
@valgur valgur requested a review from a team as a code owner June 20, 2023 12:50
@valgur valgur requested review from harrism and jrhemstad June 20, 2023 12:50
@rapids-bot
Copy link

rapids-bot bot commented Jun 20, 2023

Pull requests from external contributors require approval from a rapidsai organization member with write permissions or greater before CI can begin.

@github-actions github-actions bot added the cpp Pertains to C++ code label Jun 20, 2023
@vyasr vyasr assigned vyasr and valgur and unassigned vyasr Jun 20, 2023
@vyasr vyasr added bug Something isn't working 3 - Ready for review Ready for review by team non-breaking Non-breaking change labels Jun 20, 2023
@vyasr
Copy link
Contributor

vyasr commented Jun 20, 2023

/ok to test

@vyasr
Copy link
Contributor

vyasr commented Jun 20, 2023

Thanks for the fix @valgur!

@harrism harrism removed the 3 - Ready for review Ready for review by team label Jun 20, 2023
@harrism
Copy link
Member

harrism commented Jun 20, 2023

/merge

@rapids-bot rapids-bot bot merged commit e212256 into rapidsai:branch-23.08 Jun 20, 2023
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cpp Pertains to C++ code non-breaking Non-breaking change
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants