Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-commit hook to validate doxygen #1334

Merged
merged 3 commits into from
Sep 6, 2023

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Sep 1, 2023

Description

This change ensures that our doxygen documentation stays up to date during development. Since pre-commit also runs during CI, C++ documentation will be validated on every pull request.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr added 3 - Ready for review Ready for review by team doc Documentation non-breaking Non-breaking change labels Sep 1, 2023
@vyasr vyasr self-assigned this Sep 1, 2023
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we consider updating our supported doxygen version?

scripts/doxygen.sh Outdated Show resolved Hide resolved
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
@vyasr
Copy link
Contributor Author

vyasr commented Sep 6, 2023

Should we consider updating our supported doxygen version?

I'd like to do that in a separate PR since it'll require also fixing a new set of additional errors and I want the automated checking in place beforehand. Also I'd like to synchronize that update with a corresponding cudf PR.

@vyasr
Copy link
Contributor Author

vyasr commented Sep 6, 2023

/merge

@rapids-bot rapids-bot bot merged commit f3ca1d7 into rapidsai:branch-23.10 Sep 6, 2023
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for review Ready for review by team doc Documentation non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants