Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix else-after-throw clang tidy error #1391

Merged
merged 2 commits into from
Nov 30, 2023
Merged

Fix else-after-throw clang tidy error #1391

merged 2 commits into from
Nov 30, 2023

Conversation

harrism
Copy link
Member

@harrism harrism commented Nov 28, 2023

Description

Updates code for RMM_CUDA_TRY_ALLOC macro in detail/error.hpp to eliminate a clang-tidy error.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@harrism harrism added bug Something isn't working non-breaking Non-breaking change labels Nov 28, 2023
@harrism harrism requested a review from a team as a code owner November 28, 2023 01:38
@harrism harrism requested review from rongou and vyasr November 28, 2023 01:38
@github-actions github-actions bot added the cpp Pertains to C++ code label Nov 28, 2023
@harrism harrism changed the title Fix else-after-thrown clang tidy error Fix else-after-throw clang tidy error Nov 28, 2023
@harrism harrism self-assigned this Nov 28, 2023
@harrism
Copy link
Member Author

harrism commented Nov 30, 2023

/merge

@rapids-bot rapids-bot bot merged commit ee3817c into rapidsai:branch-24.02 Nov 30, 2023
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rongou rongou rongou approved these changes

@vyasr vyasr vyasr approved these changes

Assignees

@harrism harrism

Labels
bug Something isn't working cpp Pertains to C++ code non-breaking Non-breaking change
Projects
RMM Project Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@harrism @rongou @vyasr