Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support CUDA 12.2 #1419

Merged
merged 18 commits into from
Feb 9, 2024
Merged

Conversation

jameslamb
Copy link
Member

@jameslamb jameslamb commented Jan 5, 2024

Description

  • switches to CUDA 12.2.2 for building conda packages and wheels
  • adds new tests running against CUDA 12.2.2

Notes for Reviewers

This is part of ongoing work to build and test packages against CUDA 12.2.2 across all of RAPIDS.

For more details see:

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

Notes for Reviewers

Planning a second round of PRs to revert these references back to a proper branch-24.{nn} release branch of shared-workflows once rapidsai/shared-workflows#166 is merged.

@jameslamb jameslamb marked this pull request as ready for review January 5, 2024 20:23
@jameslamb jameslamb requested a review from a team as a code owner January 5, 2024 20:24
@harrism harrism added the feature request New feature or request label Jan 8, 2024
dependencies.yaml Outdated Show resolved Hide resolved
@jameslamb jameslamb requested a review from bdice January 11, 2024 19:25
@jakirkham jakirkham added the non-breaking Non-breaking change label Jan 11, 2024
@jameslamb jameslamb changed the title use CUDA 12.2 for building and testing wheels add CUDA 12.2 support for conda packages and wheels Jan 11, 2024
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I'll mark this as DO NOT MERGE until we get more of RAPIDS passing and we decide whether to target 24.02 or 24.04.

@bdice bdice added the 5 - DO NOT MERGE Hold off on merging; see PR for details label Jan 11, 2024
@jameslamb jameslamb changed the base branch from branch-24.02 to branch-24.04 January 22, 2024 15:37
@jameslamb jameslamb changed the title add CUDA 12.2 support for conda packages and wheels Support CUDA 12.2 Jan 25, 2024
@github-actions github-actions bot added the ci label Jan 30, 2024
We should not use the cuda-cudart-dev package in host as a means of getting a run_export of cuda-cudart in run, because it enforces an equal or greater version of cuda-cudart at runtime. This breaks CUDA minor version compatibility, where we intend to build a package with e.g. CUDA 12.2, and allow it to be run with e.g. CUDA 12.0.
@github-actions github-actions bot removed the ci label Feb 5, 2024
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified that builds and tests appear to be using the correct CUDA versions now. xref: rapidsai/build-planning#8 (comment)

@bdice bdice removed the 5 - DO NOT MERGE Hold off on merging; see PR for details label Feb 9, 2024
@bdice
Copy link
Contributor

bdice commented Feb 9, 2024

/merge

@rapids-bot rapids-bot bot merged commit a9dbf9a into rapidsai:branch-24.04 Feb 9, 2024
47 checks passed
rapids-bot bot pushed a commit that referenced this pull request Feb 20, 2024
Follow-up to #1419

For all GitHub Actions configs, replaces uses of the `test-cuda-12.2` branch on `shared-workflows`
with `branch-24.04`, now that rapidsai/shared-workflows#166 has been merged.

### Notes for Reviewers

This is part of ongoing work to build and test packages against CUDA 12.2 across all of RAPIDS.

For more details see:

* rapidsai/build-planning#7

*(created with `rapids-reviser`)*

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Ray Douglass (https://github.com/raydouglass)

URL: #1468
@jameslamb jameslamb deleted the test-cuda-12.2 branch May 2, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conda feature request New feature or request non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants