Change rmm::exec_policy to take async_resource_ref
#1449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This rewrites `rmm::exec_policy` to take a `cuda::std::async_resource_ref` instead of a plain `rmm::device_memory_resource*`. This is completely opaque to the user as the underlying `rmm::thrust_allocator` already takes a `cuda::mr::async_resource_ref` Fixes rapidsai#1448 Closes
miscco
force-pushed
the
refactor_exec_policy
branch
from
207622a
to
aba5c97
Compare
miscco
added
feature request
harrism
changed the title
rmm::exec_policy over to async_resource_refrmm::exec_policy to take async_resource_ref
harrism
approved these changes
Jan 30, 2024
miscco
commented
Feb 1, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
This rewrites
rmm::exec_policyto take acuda::std::async_resource_refinstead of a plainrmm::device_memory_resource*. This is completely opaque to the user as the underlyingrmm::thrust_allocatoralready takes acuda::mr::async_resource_refCloses #1448