Explicitly use the current device resource in DeviceBuffer #1514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#1515 tracks the broader issue |
Previously we were relying on the C++ and Python-level device resources to agree. But this need not be the case. To avoid this, first get the current deivce resource and then use it when allocating the wrapped C++ device_buffer when creating DeviceBuffers. - Closes rapidsai#1506
wence-
force-pushed
the
wence/fix/1506-partial
branch
from
ec14168
to
f0486cd
Compare
|
/merge |
|
In general I prefer to have two reviews / approvals. Especially when I am the only one to approve the Python (I'm an amateur Python programmer). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously we were relying on the C++ and Python-level device resources to agree. But this need not be the case.
To avoid this, first get the current device resource and then use it when allocating the wrapped C++ device_buffer when creating DeviceBuffers.
rmm_cupy_allocatorwith Cupy, the memory resource is constructed twice. #1506Checklist