Remove deprecated functionality #1537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harrism
added
breaking
wence-
approved these changes
Apr 16, 2024
|
/merge |
vyasr
requested changes
Apr 24, 2024
| # exclude_patterns list | ||
| if not os.path.exists(breathe_projects["librmm"] + "/deprecated.xml"): | ||
| exclude_patterns.append("librmm_docs/deprecated.rst") | ||
| suppress_warnings.append("toc.excluded") |
There was a problem hiding this comment.
What is this for? I'd guess when you exclude things it generates an extra file and then it warns about that file not being included anywhere, or something like that?
There was a problem hiding this comment.
Because deprecated is listed in the toc in the main RST file. This lets us leave it there even though the deprecated.rst file is excluded. Without this suppression you get a warning that an excluded file is in the toc.
There was a problem hiding this comment.
I didn't have a better way to conditionally remove it from the toc.
There was a problem hiding this comment.
Ah OK I see. Yeah that seems fine then.
Co-authored-by: Vyas Ramasubramani <vyas.ramasubramani@gmail.com>
Co-authored-by: Vyas Ramasubramani <vyas.ramasubramani@gmail.com>
vyasr
approved these changes
Apr 30, 2024
|
/merge |
raydouglass
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #1536
Checklist