Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove header existence tests. #1550

Merged
merged 3 commits into from
May 1, 2024
Merged

Remove header existence tests. #1550

merged 3 commits into from
May 1, 2024

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Apr 30, 2024

Description

This PR removes header existence tests from the librmm conda recipe to reduce friction when code is moved. Closes #1549.

These changes are similar to rapidsai/cudf#14072.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@bdice bdice requested a review from a team as a code owner April 30, 2024 22:45
@github-actions github-actions bot added the conda label Apr 30, 2024
@bdice bdice self-assigned this Apr 30, 2024
@bdice bdice added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Apr 30, 2024
harrism
harrism approved these changes May 1, 2024
View reviewed changes
conda/recipes/librmm/meta.yaml Outdated Show resolved Hide resolved
jakirkham
jakirkham reviewed May 1, 2024
View reviewed changes
Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Bradley! 🙏

Had a suggestion below

conda/recipes/librmm/meta.yaml Outdated Show resolved Hide resolved
@bdice
Copy link
Contributor Author

bdice commented May 1, 2024

/merge

@rapids-bot rapids-bot bot merged commit 9d0a29a into rapidsai:branch-24.06 May 1, 2024
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harrism harrism harrism approved these changes

@jakirkham jakirkham jakirkham left review comments

@wence- wence- wence- approved these changes

@raydouglass raydouglass raydouglass approved these changes

Assignees

@bdice bdice

Labels
conda improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
RMM Project Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Remove header existence tests in librmm conda recipe
5 participants
@bdice @harrism @wence- @jakirkham @raydouglass