Simplify rmm::exec_policy and refactor Thrust support
#647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please update the changelog in order to start CI tests. View the gpuCI docs here. |
harrism
added
2 - In Progress
harrism
changed the title
rmm::exec_policy and refactor Thrust support
harrism
commented
Dec 4, 2020
harrism
requested review from
rongou,
codereport and
jrhemstad
and removed request for
rongou
codereport
suggested changes
Dec 4, 2020
jrhemstad
reviewed
Dec 5, 2020
jrhemstad
reviewed
Dec 5, 2020
|
We should not merge this until corresponding PRs for cuDF and cuSpatial are merged, and this is tested with cuML and cuGraph. Update: determined that this PR is non-breaking for cuML and cuGraph, which have not been updated to use |
harrism
added
non-breaking
codereport
approved these changes
Dec 8, 2020
jrhemstad
approved these changes
Dec 8, 2020
harrism
added
6 - Okay to Auto-Merge
and removed
3 - Ready for review
kkraus14
pushed a commit
to rapidsai/cudf
that referenced
this pull request
Dec 10, 2020
Updates libcudf to use the new, simplified `rmm::exec_policy` and include the new refactored headers `rmm/exec_policy.hpp` and `rmm/device_vector.hpp` The new `exec_policy` can be passed directly to Thrust, no longer any need to call `rmm::exec_policy(stream)->on(stream)`. Depends on rapidsai/rmm#647
rapids-bot bot
pushed a commit
to rapidsai/cuspatial
that referenced
this pull request
Dec 10, 2020
Updates libcudf to use the new, simplified rmm::exec_policy and include the new refactored headers rmm/exec_policy.hpp and rmm/device_vector.hpp The new exec_policy can be passed directly to Thrust, no longer any need to call rmm::exec_policy(stream)->on(stream). Depends on rapidsai/rmm#647 Authors: - Mark Harris <mharris@nvidia.com> Approvers: - Paul Taylor - Christopher Harris URL: #331
This was referenced Dec 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #620.
This PR improves
rmm::exec_policyso you can now just passrmm::exec_policy(stream)rather thanrmm::exec_policy(stream)->on(stream). Also refactors thermm::device_vectoralias into its own header, and the newrmm::exec_policyinto its own header. The oldthrust_rmm_allocator.hstill exists for backwards compatibility. We should probably deprecate it and the oldexec_policy.#620 describes the motivation for this PR very well.