Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unknown CMake command "CPMFindPackage" #699

Merged
merged 1 commit into from
Feb 25, 2021
Merged

Fix unknown CMake command "CPMFindPackage" #699

merged 1 commit into from
Feb 25, 2021

Conversation

standbyme
Copy link
Contributor

Build RMM error:

cmake .. -DCMAKE_INSTALL_PREFIX=/install/path
-- Downloading CPM.cmake to ...
CMake Error at cmake/Modules/RMM_thirdparty.cmake:5 (CPMFindPackage):
  Unknown CMake command "CPMFindPackage".
Call Stack (most recent call first):
  CMakeLists.txt:22 (include)

@standbyme standbyme requested a review from a team as a code owner February 12, 2021 02:40
@GPUtester
Copy link
Contributor

Can one of the admins verify this patch?

@github-actions github-actions bot added the CMake label Feb 12, 2021
kkraus14
kkraus14 suggested changes Feb 12, 2021
View reviewed changes
cmake/Modules/CPM.cmake Outdated
@@ -1,6 +1,8 @@
set(CPM_DOWNLOAD_VERSION c3c7e2d9a3b890511891ffc415d7ea23c689068a) # 0.27.3
set(CPM_DOWNLOAD_VERSION 0.28.4)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use a git commit hash and the raw link to make sure that the upstream tag doesn't change out from underneath us. Any chance you could update this to follow that pattern?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finished.
Thanks for your comment : )

@kkraus14 kkraus14 added this to PR-WIP in v0.19 Release via automation Feb 12, 2021
@kkraus14 kkraus14 added bug Something isn't working non-breaking Non-breaking change labels Feb 12, 2021
@kkraus14 kkraus14 changed the base branch from branch-0.18 to branch-0.19 February 12, 2021 16:16
@harrism
Copy link
Member

harrism commented Feb 15, 2021

@germasch may want to review.

germasch
germasch approved these changes Feb 15, 2021
View reviewed changes
Copy link
Contributor

@germasch germasch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me ;)

@harrism harrism changed the title [FIX] Unknown CMake command "CPMFindPackage" Fix unknown CMake command "CPMFindPackage" Feb 15, 2021
@harrism harrism moved this from PR-WIP to PR-Needs review in v0.19 Release Feb 15, 2021
@harrism harrism added the 3 - Ready for review Ready for review by team label Feb 15, 2021
@harrism
Copy link
Member

harrism commented Feb 15, 2021

ok to test

@standbyme
Copy link
Contributor Author

@harrism hello, is there other problems? : )

v0.19 Release automation moved this from PR-Needs review to PR-Reviewer approved Feb 25, 2021
@kkraus14
Copy link
Contributor

@gpucibot merge

@rapids-bot rapids-bot bot merged commit c74c3ff into rapidsai:branch-0.19 Feb 25, 2021
v0.19 Release automation moved this from PR-Reviewer approved to Done Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkraus14 kkraus14 kkraus14 approved these changes

@germasch germasch germasch approved these changes

Assignees
No one assigned
Labels
3 - Ready for review Ready for review by team bug Something isn't working CMake non-breaking Non-breaking change
Projects
No open projects
v0.19 Release
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@standbyme @GPUtester @harrism @kkraus14 @germasch