[REVIEW] Simplify cmake cuda architectures handling #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harrism
approved these changes
Feb 17, 2021
kkraus14
added
improvement
robertmaynard
force-pushed
the
simplify_CMAKE_CUDA_ARCHITECTURES_handling
branch
3 times, most recently
from
349e691
to
7199396
Compare
robertmaynard
changed the title
Improve how we handle CUDA arch settings by moving some of the logic into the root CMakeLists. This will allow us to specify CUDA as a language in our project() call once we require CMake 3.20.
robertmaynard
force-pushed
the
simplify_CMAKE_CUDA_ARCHITECTURES_handling
branch
from
7199396
to
fa1773b
Compare
kkraus14
approved these changes
Feb 23, 2021
robertmaynard
force-pushed
the
simplify_CMAKE_CUDA_ARCHITECTURES_handling
branch
from
fa1773b
to
08a1aae
Compare
|
@robertmaynard any more changes before we merge this? Thanks! |
|
Nope!
… On Feb 24, 2021, at 11:38 AM, Keith Kraus ***@***.***> wrote:
@robertmaynard any more changes before we merge this? Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #706 as they both modify
cmake/Modules/SetGPUArchs.cmakeThis brings rmm's handling of
CMAKE_CUDA_ARCHITECTURESto match that is proposed for cudf in rapidsai/cudf#7391