Bump isort, enable Cython package resorting #806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakirkham
added
non-breaking
dillon-cullinan
approved these changes
Jun 24, 2021
|
Does this PR depend on rapidsai/integration#286 ? |
|
Ya, should hold off on this. |
|
I think it's the other way around - shouldn't we merge this in first, so that any subsequent PRs have the properly sorted Cython files that rapidsai/integration#286 enforces? See this comment |
|
Ah, my mistake. I thought you were adding functionality that doesn't exist in the current version of isort. This is safe to merge. |
|
Thanks for clarifying! |
|
@gpucibot merge |
|
Hmm, my bad - I just noticed that there were some PXD resorts that should've been merged in this that will probably cause CI failures once rapidsai/integration#286 is merged. I will open a follow up PR that applies those changes. |
|
Opened up #812 to address this |
rapids-bot bot
pushed a commit
that referenced
this pull request
Jun 24, 2021
I neglected to run the updated isort hooks from #806 before it was merged - this should ensure that rapidsai/integration#286 doesn't cause any CI failures here when it is merged. Authors: - Charles Blackmon-Luca (https://github.com/charlesbluca) Approvers: - https://github.com/jakirkham URL: #812
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With rapidsai/integration#286, the version of isort running on gpuCI will be bumped to 5.6.4, allowing us to enforce the sorting of packages in Cython (pyx, pxd) files. This PR intends to: