Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor cmake style #842

Merged

Conversation

robertmaynard
Copy link
Contributor

Remove a couple of CMake anti-patterns used in RMM. This brings RMM CMake code to match the rest of RAPIDS.

@robertmaynard robertmaynard added CMake non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Aug 10, 2021
@robertmaynard robertmaynard added this to PR-WIP in v21.10 Release via automation Aug 10, 2021
@robertmaynard robertmaynard requested a review from a team as a code owner August 10, 2021 17:38
@github-actions github-actions bot added the cpp Pertains to C++ code label Aug 10, 2021
v21.10 Release automation moved this from PR-WIP to PR-Reviewer approved Aug 11, 2021
@harrism
Copy link
Member

harrism commented Aug 11, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 23bbe74 into rapidsai:branch-21.10 Aug 11, 2021
v21.10 Release automation moved this from PR-Reviewer approved to Done Aug 11, 2021
@robertmaynard robertmaynard deleted the fea/refactor_cmake_style branch August 11, 2021 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake cpp Pertains to C++ code improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants