Use numba to get CUDA runtime version. #946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @shwina |
Can we please file an issue about this on cuda-python? |
Co-authored-by: GALI PREM SAGAR <sagarprem75@gmail.com>
bdice
force-pushed
the
fix/numba-cuda-runtime-version
branch
from
5d5ba85
to
d4bae42
Compare
galipremsagar
approved these changes
Jan 19, 2022
galipremsagar
added
non-breaking
shwina
approved these changes
Jan 19, 2022
galipremsagar
added
the
5 - Ready to Merge
Issue opened: NVIDIA/cuda-python#16 |
jakirkham
approved these changes
Jan 19, 2022
jakirkham
reviewed
Jan 19, 2022
| if status != cudart.cudaError_t.cudaSuccess: | ||
| raise CUDARuntimeError(status) | ||
| return version | ||
| # TODO: Replace this with `cuda.cudart.cudaRuntimeGetVersion()` when the |
There was a problem hiding this comment.
Maybe we should have an RMM issue about this?
harrism
approved these changes
Jan 19, 2022
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses
numbato fetch the CUDA runtime version, rather than cuda-python.The current implementation of cuda-python's
cuda.cudart.cudaRuntimeGetVersion()hard-codes the runtime version, rather than querying the runtime for its version. This is a known limitation that may not be resolved in the near term. cc: @vzhurba01