Make pool_memory_resource::pool_size() public
#962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
cpp
shwina
added
non-breaking
rongou
approved these changes
Jan 27, 2022
harrism
approved these changes
Jan 27, 2022
|
@gpucibot merge |
jakirkham
reviewed
Jan 28, 2022
python/rmm/_lib/memory_resource.pyx
Outdated
Comment on lines
304
to
305
| return (<pool_memory_resource[device_memory_resource]*>( | ||
| self.c_obj.get()))[0].pool_size() |
There was a problem hiding this comment.
This feels like a lot to cram into one line. Would it make sense to break this up a bit by assigning to variables?
There was a problem hiding this comment.
I tried to clean this up a bit. Unfortunately, unlike C++, I can't create a type alias for pool_memory_resource[device_memory_resource], so this is still a bit awkward looking.
There was a problem hiding this comment.
(Cython doesn't let you ctypedef inside a function)
There was a problem hiding this comment.
The change looks much better! Thanks Ashwin 😄
Interesting guessing you tried ctypedef? Did you try DEF? In any event this seems less critical at least from my perspective
github-actions
bot
added
cpp
jakirkham
approved these changes
Jan 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's useful to know how much memory RMM has "to itself" at any given time. When using a
pool_memory_resource, being able to query the current pool size is the only way to know that.This is to enable the use cases described in #956 (combined with a
CallbackMemoryResource, for which I'll open a subsequent PR).