Add device_buffer::ssize() and device_uvector::ssize() #966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harrism
added
improvement
rongou
approved these changes
Feb 2, 2022
jrhemstad
reviewed
Feb 2, 2022
include/rmm/device_buffer.hpp
Outdated
| @@ -315,11 +315,19 @@ class device_buffer { | |||
| void* data() noexcept { return _data; } | |||
|
|
|||
| /** | |||
| * @brief Returns size in bytes that was requested for the device memory | |||
| * allocation | |||
| * @brief Returns size in bytes of the underlying device memory storage. | |||
There was a problem hiding this comment.
The somewhat awkward original documentation was my attempt to differentiate size() and capacity(). With this change, I feel that nuance is lost.
There was a problem hiding this comment.
OK, I updated the docs to be based more on the size() and capacity() docs of std::vector, which is exactly what you had done in rmm::device_uvector already.
hyperbolic2346
approved these changes
Feb 2, 2022
jrhemstad
approved these changes
Feb 3, 2022
|
@gpucibot merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Feb 4, 2022
After #966 builds with full warnings enabled as errors could fail with the following error: ``` /miniconda3/envs/cudf_dev/include/rmm/device_buffer.hpp: In member function ‘int64_t rmm::device_buffer::ssize() const’: /home/jlowe/miniconda3/envs/cudf_dev/include/rmm/device_buffer.hpp:327:19: error: comparison of integer expressions of different signedness: ‘std::size_t’ {aka ‘long unsigned int’} and ‘long int’ [-Werror=sign-compare] 327 | assert(size() < std::numeric_limits<int64_t>::max() && "Size overflows signed integer"); | ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ cc1plus: all warnings being treated as errors ``` This fixes the warning by casting the numerical limit to `std::size_t` before comparing. Authors: - Jason Lowe (https://github.com/jlowe) Approvers: - Jake Hemstad (https://github.com/jrhemstad) - Vyas Ramasubramani (https://github.com/vyasr) URL: #970
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #927.
Adds signed size accessors (
ssize()) tormm::device_bufferandrmm::device_uvector.