Log allocation failures #988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rongou
added
3 - Ready for review
jrhemstad
reviewed
Mar 2, 2022
jrhemstad
reviewed
Mar 2, 2022
| @@ -164,7 +164,8 @@ inline std::vector<event> parse_csv(std::string const& filename) | |||
|
|
|||
| for (std::size_t i = 0; i < actions.size(); ++i) { | |||
| auto const& action = actions[i]; | |||
| RMM_EXPECTS((action == "allocate") or (action == "free"), "Invalid action string."); | |||
| RMM_EXPECTS((action == "allocate") or (action == "allocate failure") or (action == "free"), | |||
There was a problem hiding this comment.
This will break the parsing as it assumes an event can only be an action::ALLOCATE or action::FREE. But adding an allocate failure effectively adds a third kind of event.
There was a problem hiding this comment.
Adding a third event isn't quite what I meant. This parser is used for the replay benchmark as well and this will still break the replay benchmark.
Nevermind, I see the replay was already updated.
jrhemstad
reviewed
Mar 10, 2022
| logger_->info("allocate,{},{},{}", ptr, bytes, fmt::ptr(stream.value())); | ||
| return ptr; | ||
| } catch (...) { | ||
| logger_->info("allocate failure,{},{},{}", nullptr, bytes, fmt::ptr(stream.value())); |
There was a problem hiding this comment.
Documentation needs to be updated that it will log a different message for failed allocations.
harrism
approved these changes
Mar 14, 2022
jrhemstad
approved these changes
Mar 15, 2022
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now when we run out of memory, the last allocation that causes the OOM is not being logged. Adding a new
allocate failureline to the log to help with debugging. For now these lines are ignored by the replay utility.@abellina