Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add environment-agnostic scripts for running ctests and pytests #128

Merged
merged 16 commits into from
Mar 4, 2024

Conversation

trxcllnt
Copy link
Contributor

@trxcllnt trxcllnt commented Feb 7, 2024

This PR adds environment-agnostic run_{ctests,pytests}.sh scripts, and updates test_{cpp,python}.sh to call them.

The test_{cpp,python}.sh scripts assume they're running in our CI environment, and they do more than just run the tests.

This PR allows devs and downstream consumers to only run the tests, and skip the unrelated logic in test_{cpp,python}.sh.

@trxcllnt trxcllnt requested a review from a team as a code owner February 7, 2024 08:54
@trxcllnt trxcllnt added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Feb 7, 2024
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes should get wheel tests working.

ci/test_wheel.sh Show resolved Hide resolved
ci/test_wheel.sh Outdated Show resolved Hide resolved
trxcllnt and others added 2 commits February 12, 2024 12:00
Co-authored-by: Vyas Ramasubramani <vyas.ramasubramani@gmail.com>
@bdice
Copy link
Contributor

bdice commented Mar 4, 2024

/merge

@rapids-bot rapids-bot bot merged commit 0668299 into rapidsai:branch-24.04 Mar 4, 2024
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants