Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DOFileCacheDriver.php #5

Merged
merged 3 commits into from Jan 11, 2020
Merged

Conversation

200MPH
Copy link
Contributor

@200MPH 200MPH commented Jan 6, 2020

Save cache did not work without this extra line.
After adding it it's caching as expected :)

Save cache did not work without this extra line.
@coveralls
Copy link

coveralls commented Jan 6, 2020

Pull Request Test Coverage Report for Build 38

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.09%) to 94.828%

Totals Coverage Status
Change from base Build 36: 0.09%
Covered Lines: 110
Relevant Lines: 116

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jan 6, 2020

Pull Request Test Coverage Report for Build 40

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.09%) to 94.828%

Totals Coverage Status
Change from base Build 36: 0.09%
Covered Lines: 55
Relevant Lines: 58

💛 - Coveralls

@DivineOmega
Copy link
Member

This looks great, thanks.

Could you fix the issues reported by Style CI and remove HHVM support from the Travis file?

@200MPH
Copy link
Contributor Author

200MPH commented Jan 7, 2020 via email

Removed HHVM from Travis file
Bracket alignment to meet StyleCI requirements
@200MPH
Copy link
Contributor Author

200MPH commented Jan 10, 2020

All looks good :)

@DivineOmega DivineOmega merged commit cfa6e68 into rapidwebltd:master Jan 11, 2020
@DivineOmega
Copy link
Member

Thanks! Released as v5.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants