Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement build, structure and fix jest tests #1221

Merged
merged 5 commits into from
Mar 31, 2019
Merged

Enhancement build, structure and fix jest tests #1221

merged 5 commits into from
Mar 31, 2019

Conversation

rivajunior
Copy link
Contributor

@rivajunior rivajunior commented Mar 30, 2019

Is this a fix, enhancement or language pack?

This is both, fix and enhancement.

On this pull request I've made the following changes:

@rappasoft
Copy link
Owner

Great PR. Thanks for listing all the changes with sources, I have no problem with any of this I just need to test it all my self before merging in.

@rivajunior
Copy link
Contributor Author

Great PR. Thanks for listing all the changes with sources, I have no problem with any of this I just need to test it all my self before merging in.

I forgot to say that I've tested the scripts on my windows 10 (bash, cmd, powershell) and on ubuntu 18.04 (homestead)

@rappasoft
Copy link
Owner

rappasoft commented Mar 31, 2019

The only difference I see is that font awesome can no longer be used on the backend, I get that coreui uses simple line icons (which is annoying to begin with) but we should still have the option to use them globally. So i'm probably going to modify that.

Edit: There are actually a few on the backend that don't currently appear because of this, so we have to make it global somewhere.

@rappasoft rappasoft merged commit 147588b into rappasoft:development Mar 31, 2019
@rivajunior rivajunior deleted the node_optimizations branch March 31, 2019 22:58
@rivajunior
Copy link
Contributor Author

The only difference I see is that font awesome can no longer be used on the backend, I get that coreui uses simple line icons (which is annoying to begin with) but we should still have the option to use them globally. So i'm probably going to modify that.

Edit: There are actually a few on the backend that don't currently appear because of this, so we have to make it global somewhere.

Don't worry, I'll do that.

I don't have sure, but I think we don't need to use Simple Line Icons. It is used on CoreUI examples, but we not obligated to use it. So if we remove and use only font-awesome, it can be lighter than use two icon fonts.

@rappasoft
Copy link
Owner

I did it already: 7b3c896

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants