Load Bootstrap and Fontawesome from vendor

[gbrock]

Primarily, this fork removes a lot of resource files (Bootstrap and FontAwesome styles and fonts) in favor of loading them via composer.json.

As a bonus, this fork also allows users to supply their own Bootstrap and FontAwesome variables (frontend/variable-overrides).

Perhaps overly-opinionated, this fork also removes the HTML5 Boilerplate CSS defaults (previously found in frontend/main) in favor of the defaults provided by Bootstrap. This has the (perhaps desirable) side-effect of drastically shortening the main stylesheets.

Overall, this fork is designed to clean up the process of rendering vendor libraries and user stylesheets, both LESS and SASS, and to put package control in charge of keeping these libraries up-to-date.

Potential Issues:

• The backend styles remain largely untouched as it seems they are still under more serious development (i.e. backend/main.scss).
• JS files should not have been affected by these changes. It might be prudent to also use the package-controlled Bootstrap JS.

[rappasoft]

Wow good work. Let me go over it, it seems like a better solutions so as soon as I understand it all I don't see a reason why it can't be merged.

[rappasoft]

Also, your first issue: backend/main.scss is a compiled version of the LESS for the AdminLTE theme, since it only comes in LESS, I wasn't going to take the time to convert it to SCSS. So it is not under development by me anyway, I figured most people would swap out the theme for their own anyway.

[gbrock]

Thanks!

re: backend/main.scss: Understood.

[rappasoft]

I like this it just needs some tweaks:

1. The compiler is bitching at me unless I put the font import url in quotes in backend/main.scss
2. Even after that for some reason the font weights are changing on the frontend between the 2 versions. See attached.

[rappasoft]

I'm gonna try to merge and fix it if you don't mind.

[rappasoft]

Merged. Pull it and see if it's what you intended.

[gbrock]

Everything seems to be working great, except for variable overrides in the SASS version. The overrides need to come before the variables they'll override, unlike in LESS, where they must be declared later. This also takes care of the font weight issue you mentioned: it should override the font as intended when loaded like so (assets/sass/frontend/main.scss):

// Any Bootstrap or FontAwesome-specific variables added here will overwrite the defaults.
@import "variable-overrides";

@import '../../../../vendor/twbs/bootstrap-sass/assets/stylesheets/_bootstrap';
@import '../../../../vendor/fortawesome/font-awesome/scss/font-awesome';


// Front-end SCSS goes here.

...while the LESS version can remain as-is:

@import '../../../../vendor/twbs/bootstrap/less/bootstrap';
@import '../../../../vendor/fortawesome/font-awesome/less/font-awesome';

// Any Bootstrap or FontAwesome-specific variables added here will overwrite the defaults.
@import 'variable-overrides';

// Front-end LESS goes here.

[rappasoft]

Ok fixed, still weight issue though.

[gbrock]

Hmm... Doesn't look like the /public assets have changed at all? Gulp will need to re-render the SCSS files with the correct variables (in this case, $font-family-sans-serif was being correct applied through LESS but not through SASS).

[gbrock]

Just double-checked after pulling the latest changes: rendering either SASS or LESS results in the same font/weight for me, so it seems good as far as I can tell.

I'm a little green with git; if there's anything more specific I can do to help troubleshoot this further please let me know.

[rappasoft]

I'm probably just as green. It's fine by me.